From: Andrey Smirnov Date: Mon, 7 Nov 2016 16:53:23 +0000 (-0800) Subject: pinctrl-sx150x: Remove magic numbers from sx150x_reset X-Git-Tag: v4.14-rc1~1939^2~43 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f9038d603a64dd0f42a3773c96c72809382066de;p=platform%2Fkernel%2Flinux-rpi.git pinctrl-sx150x: Remove magic numbers from sx150x_reset Tested-by: Neil Armstrong Acked-by: Neil Armstrong Signed-off-by: Andrey Smirnov Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c index 56abe36..dc1341f 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -49,6 +49,8 @@ enum { SX150X_MAX_REGISTER = 0xad, SX150X_IRQ_TYPE_EDGE_RISING = 0x1, SX150X_IRQ_TYPE_EDGE_FALLING = 0x2, + SX150X_789_RESET_KEY1 = 0x12, + SX150X_789_RESET_KEY2 = 0x34, }; struct sx150x_123_pri { @@ -771,13 +773,13 @@ static int sx150x_reset(struct sx150x_pinctrl *pctl) err = i2c_smbus_write_byte_data(pctl->client, pctl->data->pri.x789.reg_reset, - 0x12); + SX150X_789_RESET_KEY1); if (err < 0) return err; err = i2c_smbus_write_byte_data(pctl->client, pctl->data->pri.x789.reg_reset, - 0x34); + SX150X_789_RESET_KEY2); return err; }