From: Michal Kazior Date: Fri, 8 Jun 2012 08:55:44 +0000 (+0200) Subject: cfg80211: check iface combinations only when iface is running X-Git-Tag: v3.5-rc5~17^2~34^2~1^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f8cdddb8d61d16a156229f0910f7ecfc7a82c003;p=profile%2Fcommon%2Fkernel-common.git cfg80211: check iface combinations only when iface is running Don't validate interface combinations on a stopped interface. Otherwise we might end up being able to create a new interface with a certain type, but won't be able to change an existing interface into that type. This also skips some other functions when interface is stopped and changing interface type. Signed-off-by: Michal Kazior Signed-off-by: Johannes Berg --- diff --git a/net/wireless/util.c b/net/wireless/util.c index 8f2d68f..316cfd0 100644 --- a/net/wireless/util.c +++ b/net/wireless/util.c @@ -804,7 +804,7 @@ int cfg80211_change_iface(struct cfg80211_registered_device *rdev, ntype == NL80211_IFTYPE_P2P_CLIENT)) return -EBUSY; - if (ntype != otype) { + if (ntype != otype && netif_running(dev)) { err = cfg80211_can_change_interface(rdev, dev->ieee80211_ptr, ntype); if (err)