From: Dan Carpenter Date: Fri, 9 Dec 2011 06:35:39 +0000 (+0300) Subject: nfc: signedness bug in __nci_request() X-Git-Tag: v3.2~1^2^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f8c141c3e915e3a040d4c1badde28e23f8cbe255;p=platform%2Fkernel%2Flinux-stable.git nfc: signedness bug in __nci_request() wait_for_completion_interruptible_timeout() returns -ERESTARTSYS if interrupted so completion_rc needs to be signed. The current code probably returns -ETIMEDOUT if we hit this situation, but after this patch is applied it will return -ERESTARTSYS. Signed-off-by: Dan Carpenter Signed-off-by: John W. Linville --- diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index 4047e29..25dae3f 100644 --- a/net/nfc/nci/core.c +++ b/net/nfc/nci/core.c @@ -68,7 +68,7 @@ static int __nci_request(struct nci_dev *ndev, __u32 timeout) { int rc = 0; - unsigned long completion_rc; + long completion_rc; ndev->req_status = NCI_REQ_PEND;