From: Christian Lütke-Stetzkamp Date: Sat, 7 Apr 2018 08:16:25 +0000 (+0200) Subject: staging: mt7621-mmc: Remove redundant opcode check X-Git-Tag: v4.19~841^2~615 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f89ce734cbe53f96480eb3110dc676c02de42cb7;p=platform%2Fkernel%2Flinux-rpi.git staging: mt7621-mmc: Remove redundant opcode check The opcode check in msdc_command_start is redundant in case of MMC_SET_RELATIVE_ADDR, this is 3 like SD_SEND_RELATIVE_ADDR, so the second check can be removed. Reported-by: Dan Carpenter Signed-off-by: Christian Lütke-Stetzkamp Reviewed-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index feebeed..7f0fcf3 100644 --- a/drivers/staging/mt7621-mmc/sd.c +++ b/drivers/staging/mt7621-mmc/sd.c @@ -875,7 +875,7 @@ static unsigned int msdc_command_start(struct msdc_host *host, */ if (opcode == MMC_SEND_OP_COND || opcode == SD_APP_OP_COND) { resp = RESP_R3; - } else if (opcode == MMC_SET_RELATIVE_ADDR || opcode == SD_SEND_RELATIVE_ADDR) { + } else if (opcode == MMC_SET_RELATIVE_ADDR) { resp = (mmc_cmd_type(cmd) == MMC_CMD_BCR) ? RESP_R6 : RESP_R1; } else if (opcode == MMC_FAST_IO) { resp = RESP_R4;