From: Rob Herring Date: Wed, 5 Dec 2018 19:50:19 +0000 (-0600) Subject: char/rtc: Use of_node_name_eq for node name comparisons X-Git-Tag: v5.15~7298^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f88fd666051b08eb3f3118e2dd8508bf0247af4c;p=platform%2Fkernel%2Flinux-starfive.git char/rtc: Use of_node_name_eq for node name comparisons Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. The open coded iterating thru the child node names is converted to use for_each_child_of_node() instead. Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Signed-off-by: Rob Herring Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c index 4948c8b..62b7c72 100644 --- a/drivers/char/rtc.c +++ b/drivers/char/rtc.c @@ -866,8 +866,8 @@ static int __init rtc_init(void) #ifdef CONFIG_SPARC32 for_each_node_by_name(ebus_dp, "ebus") { struct device_node *dp; - for (dp = ebus_dp; dp; dp = dp->sibling) { - if (!strcmp(dp->name, "rtc")) { + for_each_child_of_node(ebus_dp, dp) { + if (of_node_name_eq(dp, "rtc")) { op = of_find_device_by_node(dp); if (op) { rtc_port = op->resource[0].start;