From: Sebastian Dröge Date: Sat, 8 Feb 2014 19:19:53 +0000 (+0100) Subject: ges-group: Properly check for integer underflows X-Git-Tag: 1.19.3~493^2~1650 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f88cc0f43372c28b594a610cb1f00cca9125e273;p=platform%2Fupstream%2Fgstreamer.git ges-group: Properly check for integer underflows error: comparison of unsigned expression < 0 is always false --- diff --git a/ges/ges-group.c b/ges/ges-group.c index 5bbc6cb..f30b9c9 100644 --- a/ges/ges-group.c +++ b/ges/ges-group.c @@ -162,7 +162,7 @@ _child_group_priority_changed (GESTimelineElement * child, offset = _ges_container_get_priority_offset (container, child); - if (_PRIORITY (group) + offset < 0 || + if (_PRIORITY (group) < offset || (GES_TIMELINE_ELEMENT_TIMELINE (group) && _PRIORITY (group) + offset + GES_CONTAINER_HEIGHT (group) > g_list_length (GES_TIMELINE_ELEMENT_TIMELINE (group)->layers))) {