From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 14 Jan 2019 10:49:46 +0000 (+0300)
Subject: drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump()
X-Git-Tag: v5.4-rc1~1388^2~3^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f8261c376e7f8cb9024af5a6c54be540c7f9108e;p=platform%2Fkernel%2Flinux-rpi.git

drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump()

The etnaviv_gem_get_pages() never returns NULL.  It returns error
pointers on error.

Fixes: a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
index 3fbb485..33854c9 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
@@ -215,7 +215,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu)
 		mutex_lock(&obj->lock);
 		pages = etnaviv_gem_get_pages(obj);
 		mutex_unlock(&obj->lock);
-		if (pages) {
+		if (!IS_ERR(pages)) {
 			int j;
 
 			iter.hdr->data[0] = bomap - bomap_start;