From: Niklas Cassel <niklas.cassel@wdc.com>
Date: Mon, 31 Jul 2023 14:34:19 +0000 (+0200)
Subject: ata: sata_sx4: drop already completed TODO
X-Git-Tag: v6.6.7~1965^2~32
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f810b81ce897b323e3cc5664194b92b67462d534;p=platform%2Fkernel%2Flinux-starfive.git

ata: sata_sx4: drop already completed TODO

The TODO claims that the pdc_20621_ops should set the .inherits
function pointer to &ata_base_port_ops after it has been converted
to use the new EH.

However, the driver was converted to use the new EH a long time ago,
in commit 67651ee5710c ("[libata] sata_sx4: convert to new exception
handling methods"), which also did set .inherits function pointer to
&ata_sff_port_ops (and ata_sff_port_ops itself has .inherits set to
&ata_base_port_ops).

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---

diff --git a/drivers/ata/sata_sx4.c b/drivers/ata/sata_sx4.c
index ccc0160..b51d7a9 100644
--- a/drivers/ata/sata_sx4.c
+++ b/drivers/ata/sata_sx4.c
@@ -232,7 +232,6 @@ static const struct scsi_host_template pdc_sata_sht = {
 	.dma_boundary		= ATA_DMA_BOUNDARY,
 };
 
-/* TODO: inherit from base port_ops after converting to new EH */
 static struct ata_port_operations pdc_20621_ops = {
 	.inherits		= &ata_sff_port_ops,