From: Dinghao Liu Date: Mon, 1 Mar 2021 12:50:57 +0000 (+0800) Subject: drivers: misc: ad525x_dpot: Add missing check in dpot_read_spi X-Git-Tag: v5.15~1317^2~104 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f8096ff38d5f62d8a2c473e1bec0163a1b2b86d8;p=platform%2Fkernel%2Flinux-starfive.git drivers: misc: ad525x_dpot: Add missing check in dpot_read_spi The use of dpot_read_r8d8() after checking dpot->uid is similar. However, we check the return value and return an error code only in one path, which is odd. Link: https://lore.kernel.org/r/20210301125057.28819-1-dinghao.liu@zju.edu.cn Signed-off-by: Dinghao Liu Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index 6f16452..5d8f3f6 100644 --- a/drivers/misc/ad525x_dpot.c +++ b/drivers/misc/ad525x_dpot.c @@ -139,6 +139,9 @@ static s32 dpot_read_spi(struct dpot_data *dpot, u8 reg) value = dpot_read_r8d8(dpot, DPOT_AD5291_READ_RDAC << 2); + if (value < 0) + return value; + if (dpot->uid == DPOT_UID(AD5291_ID)) value = value >> 2;