From: Gao Feng Date: Tue, 31 Oct 2017 10:25:37 +0000 (+0800) Subject: ppp: Destroy the mutex when cleanup X-Git-Tag: v4.14.8~85 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f7ee900a4f2c76902ce368e93d34b7580cc7ff04;p=platform%2Fkernel%2Flinux-rpi.git ppp: Destroy the mutex when cleanup [ Upstream commit f02b2320b27c16b644691267ee3b5c110846f49e ] The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the good readbility, it's better to invoke it in exit func when the init func invokes mutex_init. Signed-off-by: Gao Feng Acked-by: Guillaume Nault Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index e365866..bf14c51 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c @@ -959,6 +959,7 @@ static __net_exit void ppp_exit_net(struct net *net) unregister_netdevice_many(&list); rtnl_unlock(); + mutex_destroy(&pn->all_ppp_mutex); idr_destroy(&pn->units_idr); }