From: Al Viro Date: Mon, 4 May 2015 00:59:58 +0000 (-0400) Subject: trailing_symlink: nd->depth massage, part 5 X-Git-Tag: v4.2-rc1~2^2~105 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f7df08ee05db41c6d2ec498703401197f6b68373;p=platform%2Fkernel%2Flinux-exynos.git trailing_symlink: nd->depth massage, part 5 move increment of ->depth to the point where we'd discovered that get_link() has not returned an error, adjust exits accordingly. Signed-off-by: Al Viro --- diff --git a/fs/namei.c b/fs/namei.c index cf5009b..5753f46 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2009,8 +2009,11 @@ static int trailing_symlink(struct nameidata *nd) s = get_link(nd); if (unlikely(IS_ERR(s))) return PTR_ERR(s); - if (unlikely(!s)) + nd->depth++; + if (unlikely(!s)) { + nd->depth--; return 0; + } if (*s == '/') { if (!nd->root.mnt) set_root(nd); @@ -2020,12 +2023,14 @@ static int trailing_symlink(struct nameidata *nd) nd->flags |= LOOKUP_JUMPED; } nd->inode = nd->path.dentry->d_inode; - nd->depth++; error = link_path_walk(s, nd); - nd->depth--; - if (unlikely(error)) + if (unlikely(error)) { + nd->depth--; put_link(nd); - return error; + return error; + } + nd->depth--; + return 0; } static inline int lookup_last(struct nameidata *nd)