From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Fri, 11 Nov 2022 09:20:44 +0000 (+0000)
Subject: net: mhi: Fix memory leak in mhi_net_dellink()
X-Git-Tag: v6.6.17~6176^2~19
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f7c125bd79f50ec6094761090be81d02726ec6f4;p=platform%2Fkernel%2Flinux-rpi.git

net: mhi: Fix memory leak in mhi_net_dellink()

MHI driver registers network device without setting the
needs_free_netdev flag, and does NOT call free_netdev() when
unregisters network device, which causes a memory leak.

This patch calls free_netdev() to fix it since netdev_priv
is used after unregister.

Fixes: 13adac032982 ("net: mhi_net: Register wwan_ops for link creation")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c
index 0b1b6f6..0b9d379 100644
--- a/drivers/net/mhi_net.c
+++ b/drivers/net/mhi_net.c
@@ -343,6 +343,8 @@ static void mhi_net_dellink(struct mhi_device *mhi_dev, struct net_device *ndev)
 
 	kfree_skb(mhi_netdev->skbagg_head);
 
+	free_netdev(ndev);
+
 	dev_set_drvdata(&mhi_dev->dev, NULL);
 }