From: Alyssa Rosenzweig Date: Wed, 15 May 2019 01:28:08 +0000 (+0000) Subject: panfrost/midgard: Enable integer constant inlining X-Git-Tag: upstream/19.3.0~6265 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f73c0b73ec28b2fd0d98b027491806336e4768eb;p=platform%2Fupstream%2Fmesa.git panfrost/midgard: Enable integer constant inlining Midgard ALU features two types of constants: embedded constants (128-bit chunk, zero/one per schedule bundle) and inline constants (16-bit splattered into the op, second source if present). Inline constants are much more efficient from a space and scheduling freedom standpoint, so it's desirable to inline when possible. Now that integer ops are well understood and in use, we enable inlining of integers constants in addition to floats (which have been inlined since forever). Signed-off-by: Alyssa Rosenzweig --- diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index 5354c06..421a334 100644 --- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c +++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c @@ -3134,11 +3134,7 @@ embedded_to_inline_constant(compiler_context *ctx) /* Scale constant appropriately, if we can legally */ uint16_t scaled_constant = 0; - /* XXX: Check legality */ if (midgard_is_integer_op(op)) { - /* TODO: Inline integer */ - continue; - unsigned int *iconstants = (unsigned int *) ins->constants; scaled_constant = (uint16_t) iconstants[component];