From: Tom Gundersen <teg@jklm.no>
Date: Sun, 31 May 2015 20:38:30 +0000 (+0200)
Subject: udevd: don't sanitize fd 0,1,2
X-Git-Tag: v221~235
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f6fd40d16adbd0f9ddbb1f24b4b8734fd8790ad0;p=platform%2Fupstream%2Fsystemd.git

udevd: don't sanitize fd 0,1,2

Kay said: 'it is from ancient times, when we started udevd from the
kernel's usermodhelper which had no fd 0,1,2'.
---

diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index fae8f78..c021e80 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -1628,23 +1628,6 @@ int main(int argc, char *argv[]) {
                 log_debug("set children_max to %u", arg_children_max);
         }
 
-        /* before opening new files, make sure std{in,out,err} fds are in a sane state */
-        if (arg_daemonize) {
-                int fd;
-
-                fd = open("/dev/null", O_RDWR);
-                if (fd < 0)
-                        log_error("cannot open /dev/null");
-                else {
-                        if (write(STDOUT_FILENO, 0, 0) < 0)
-                                dup2(fd, STDOUT_FILENO);
-                        if (write(STDERR_FILENO, 0, 0) < 0)
-                                dup2(fd, STDERR_FILENO);
-                        if (fd > STDERR_FILENO)
-                                close(fd);
-                }
-        }
-
         /* set umask before creating any file/directory */
         r = chdir("/");
         if (r < 0) {