From: Rafal Krypa <r.krypa@samsung.com>
Date: Mon, 2 Jan 2017 10:45:37 +0000 (+0100)
Subject: Fix memory leak from cynara_async_configuration_create
X-Git-Tag: submit/tizen_3.0/20170105.051635~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f6e1cc2104c31e9b8d56ecf30bd2003dab41b51b;p=platform%2Fcore%2Fsecurity%2Fsecurity-manager.git

Fix memory leak from cynara_async_configuration_create

The previous patch has introduced a memory leak by always passing NULL
pointer to cynara_async_configuration_destroy instead of proper pointer.

Change-Id: I252e3c36b02e493f6cac6b4718edddb282d0c9eb
Signed-off-by: Rafal Krypa <r.krypa@samsung.com>
---

diff --git a/src/common/cynara.cpp b/src/common/cynara.cpp
index 41f975a2..3be57a71 100644
--- a/src/common/cynara.cpp
+++ b/src/common/cynara.cpp
@@ -691,9 +691,10 @@ Cynara::Cynara()
     pollFds[1].events = 0;
 
     cynara_async_configuration *p_conf = nullptr;
-    auto confPtr = makeUnique(p_conf, cynara_async_configuration_destroy);
     checkCynaraError(cynara_async_configuration_create(&p_conf),
                      "Cannot create cynara async configuration");
+    auto confPtr = makeUnique(p_conf, cynara_async_configuration_destroy);
+
     checkCynaraError(cynara_async_configuration_set_cache_size(p_conf, CACHE_SIZE),
             "Cannot set cynara async configuration cache size");
     checkCynaraError(