From: Eric Gouriou <egouriou@google.com>
Date: Mon, 23 May 2011 01:33:00 +0000 (-0400)
Subject: ext4: fix unbalanced up_write() in ext4_ext_truncate() error path
X-Git-Tag: v3.0-rc1~140^2~22
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f6d2f6b327ceef5c689581529a852dc6ec3b74a6;p=profile%2Fivi%2Fkernel-x86-ivi.git

ext4: fix unbalanced up_write() in ext4_ext_truncate() error path

ext4_ext_truncate() should not invoke up_write(&EXT4_I(inode)->i_data_sem)
when ext4_orphan_add() returns an error, as it hasn't performed a
down_write() yet. This trivial patch fixes this by moving the up_write()
invocation above the out_stop label.

Signed-off-by: Eric Gouriou <egouriou@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 4444317..4e2bdc2 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3450,8 +3450,9 @@ void ext4_ext_truncate(struct inode *inode)
 	if (IS_SYNC(inode))
 		ext4_handle_sync(handle);
 
-out_stop:
 	up_write(&EXT4_I(inode)->i_data_sem);
+
+out_stop:
 	/*
 	 * If this was a simple ftruncate() and the file will remain alive,
 	 * then we need to clear up the orphan record which we created above.