From: Andrzej Pietrasiewicz Date: Mon, 13 Jan 2014 15:41:22 +0000 (+0100) Subject: usb: gadget: FunctionFS: dereference ffs_dev conditionally X-Git-Tag: submit/tizen/20141121.110247~2687 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f6c0e5db47d7c39682ca27ea65da94fcb2537ddb;p=platform%2Fkernel%2Flinux-3.10.git usb: gadget: FunctionFS: dereference ffs_dev conditionally ffs_dev->ffs_release_dev_callback should be accessed only if ffs_dev is not NULL. Signed-off-by: Andrzej Pietrasiewicz --- diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c index b70b9be..1f8629a 100644 --- a/drivers/usb/gadget/f_fs.c +++ b/drivers/usb/gadget/f_fs.c @@ -2592,11 +2592,12 @@ static void ffs_release_dev(struct ffs_data *ffs_data) ffs_dev_lock(); ffs_dev = ffs_data->private_data; - if (ffs_dev) + if (ffs_dev) { ffs_dev->mounted = false; - - if (ffs_dev->ffs_release_dev_callback) - ffs_dev->ffs_release_dev_callback(ffs_dev); + + if (ffs_dev->ffs_release_dev_callback) + ffs_dev->ffs_release_dev_callback(ffs_dev); + } ffs_dev_unlock(); }