From: Alexey Bataev Date: Tue, 10 Jan 2023 12:34:16 +0000 (-0800) Subject: [X86][NFC]Move and rephrase the comment, NFC X-Git-Tag: upstream/17.0.6~21565 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f698c2134503e6722a0da33c5e68e0df166579a2;p=platform%2Fupstream%2Fllvm.git [X86][NFC]Move and rephrase the comment, NFC --- diff --git a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp index 5b6c7d86cebe..d153fb9c310c 100644 --- a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp +++ b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp @@ -4333,6 +4333,8 @@ InstructionCost X86TTIImpl::getVectorInstrCost(unsigned Opcode, Type *Val, MVT MScalarTy = LT.second.getScalarType(); auto IsCheapPInsrPExtrInsertPS = [&]() { + // Assume pinsr/pextr XMM <-> GPR is relatively cheap on all targets. + // Also, assume insertps is relatively cheap on all >= SSE41 targets. return (MScalarTy == MVT::i16 && ST->hasSSE2()) || (MScalarTy.isInteger() && ST->hasSSE41()) || (MScalarTy == MVT::f32 && ST->hasSSE41() && @@ -4371,8 +4373,7 @@ InstructionCost X86TTIImpl::getVectorInstrCost(unsigned Opcode, Type *Val, if (auto *Entry = CostTableLookup(SLMCostTbl, ISD, MScalarTy)) return Entry->Cost + RegisterFileMoveCost; - // Assume pinsr/pextr XMM <-> GPR is relatively cheap on all targets. - // Assume insertps is relatively cheap on all targets. + // Consider cheap cases. if (IsCheapPInsrPExtrInsertPS()) return 1 + RegisterFileMoveCost;