From: Johan Hovold <johan@hovoldconsulting.com>
Date: Wed, 4 Nov 2015 17:55:16 +0000 (+0100)
Subject: greybus: es2: separate stopping and deallocating urbs
X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1059
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f6624ca77cbb4ce799a0642207fdb20e98d32777;p=platform%2Fkernel%2Flinux-rpi.git

greybus: es2: separate stopping and deallocating urbs

Separate stopping and deallocating our in-urbs.

This will facilitate implementing proper host-device life-time management.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index 1562696..75052af 100644
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -238,6 +238,18 @@ err_kill_urbs:
 	return ret;
 }
 
+static void es2_cport_in_disable(struct es2_ap_dev *es2,
+				struct es2_cport_in *cport_in)
+{
+	struct urb *urb;
+	int i;
+
+	for (i = 0; i < NUM_CPORT_IN_URB; ++i) {
+		urb = cport_in->urb[i];
+		usb_kill_urb(urb);
+	}
+}
+
 static struct urb *next_free_urb(struct es2_ap_dev *es2, gfp_t gfp_mask)
 {
 	struct urb *urb = NULL;
@@ -547,6 +559,9 @@ static void ap_disconnect(struct usb_interface *interface)
 	if (!es2)
 		return;
 
+	for (i = 0; i < NUM_BULKS; ++i)
+		es2_cport_in_disable(es2, &es2->cport_in[i]);
+
 	usb_log_disable(es2);
 
 	/* Tear down everything! */
@@ -569,7 +584,6 @@ static void ap_disconnect(struct usb_interface *interface)
 
 			if (!urb)
 				break;
-			usb_kill_urb(urb);
 			usb_free_urb(urb);
 			kfree(cport_in->buffer[i]);
 			cport_in->buffer[i] = NULL;