From: Julia Lawall Date: Sun, 16 Dec 2012 19:30:02 +0000 (-0800) Subject: arch/arm/mach-omap2/dpll3xxx.c: drop if around WARN_ON X-Git-Tag: v3.8-rc2~14^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f64d204b5cf21b282445ba2fa357d970028c9f52;p=profile%2Fivi%2Fkernel-x86-ivi.git arch/arm/mach-omap2/dpll3xxx.c: drop if around WARN_ON Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ - if (e) WARN_ON(1); + WARN_ON(e); // Signed-off-by: Julia Lawall Signed-off-by: Tony Lindgren --- diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c index fafb28c..bebd7ed 100644 --- a/arch/arm/mach-omap2/dpll3xxx.c +++ b/arch/arm/mach-omap2/dpll3xxx.c @@ -485,8 +485,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, if (!cpu_is_omap44xx() && !cpu_is_omap3630()) { freqsel = _omap3_dpll_compute_freqsel(clk, dd->last_rounded_n); - if (!freqsel) - WARN_ON(1); + WARN_ON(!freqsel); } pr_debug("%s: %s: set rate: locking rate to %lu.\n",