From: Ben Noordhuis Date: Thu, 3 Oct 2013 09:03:46 +0000 (+0200) Subject: src: add JS start/stop methods for idle notifier X-Git-Tag: v0.11.8~51 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f649626c6faef9d74c1e77608f952b06f4c5205b;p=platform%2Fupstream%2Fnodejs.git src: add JS start/stop methods for idle notifier The previous commit changes the profiler idle notifier so that it only gets started when a --prof or --prof_lazy argument is specified on the command line. This commit adds two internal methods to the process object that allows one to start and stop the idle notifier programmatically. --- diff --git a/src/node.cc b/src/node.cc index 5927867..b29fa35 100644 --- a/src/node.cc +++ b/src/node.cc @@ -2294,6 +2294,40 @@ static void NeedImmediateCallbackSetter( } +void SetIdle(uv_prepare_t* handle, int) { + Environment* env = Environment::from_idle_prepare_handle(handle); + env->isolate()->GetCpuProfiler()->SetIdle(true); +} + + +void ClearIdle(uv_check_t* handle, int) { + Environment* env = Environment::from_idle_check_handle(handle); + env->isolate()->GetCpuProfiler()->SetIdle(false); +} + + +void StartProfilerIdleNotifier(Environment* env) { + uv_prepare_start(env->idle_prepare_handle(), SetIdle); + uv_check_start(env->idle_check_handle(), ClearIdle); +} + + +void StopProfilerIdleNotifier(Environment* env) { + uv_prepare_stop(env->idle_prepare_handle()); + uv_check_stop(env->idle_check_handle()); +} + + +void StartProfilerIdleNotifier(const FunctionCallbackInfo& args) { + StartProfilerIdleNotifier(Environment::GetCurrent(args.GetIsolate())); +} + + +void StopProfilerIdleNotifier(const FunctionCallbackInfo& args) { + StopProfilerIdleNotifier(Environment::GetCurrent(args.GetIsolate())); +} + + #define READONLY_PROPERTY(obj, str, var) \ do { \ obj->Set(OneByteString(node_isolate, str), var, v8::ReadOnly); \ @@ -2465,6 +2499,12 @@ void SetupProcessObject(Environment* env, DebugPortSetter); // define various internal methods + NODE_SET_METHOD(process, + "_startProfilerIdleNotifier", + StartProfilerIdleNotifier); + NODE_SET_METHOD(process, + "_stopProfilerIdleNotifier", + StopProfilerIdleNotifier); NODE_SET_METHOD(process, "_getActiveRequests", GetActiveRequests); NODE_SET_METHOD(process, "_getActiveHandles", GetActiveHandles); NODE_SET_METHOD(process, "reallyExit", Exit); @@ -3218,18 +3258,6 @@ void EmitExit(Environment* env) { } -void SetIdle(uv_prepare_t* handle, int) { - Environment* env = Environment::from_idle_prepare_handle(handle); - env->isolate()->GetCpuProfiler()->SetIdle(true); -} - - -void ClearIdle(uv_check_t* handle, int) { - Environment* env = Environment::from_idle_check_handle(handle); - env->isolate()->GetCpuProfiler()->SetIdle(false); -} - - Environment* CreateEnvironment(Isolate* isolate, int argc, const char* const* argv, @@ -3246,15 +3274,6 @@ Environment* CreateEnvironment(Isolate* isolate, reinterpret_cast(env->immediate_check_handle())); uv_idle_init(env->event_loop(), env->immediate_idle_handle()); - Local process_template = FunctionTemplate::New(); - process_template->SetClassName(FIXED_ONE_BYTE_STRING(isolate, "process")); - - Local process_object = process_template->GetFunction()->NewInstance(); - env->set_process_object(process_object); - - SetupProcessObject(env, argc, argv, exec_argc, exec_argv); - Load(env); - // Inform V8's CPU profiler when we're idle. The profiler is sampling-based // but not all samples are created equal; mark the wall clock time spent in // epoll_wait() and friends so profiling tools can filter it out. The samples @@ -3274,6 +3293,15 @@ Environment* CreateEnvironment(Isolate* isolate, uv_check_start(env->idle_check_handle(), ClearIdle); } + Local process_template = FunctionTemplate::New(); + process_template->SetClassName(FIXED_ONE_BYTE_STRING(isolate, "process")); + + Local process_object = process_template->GetFunction()->NewInstance(); + env->set_process_object(process_object); + + SetupProcessObject(env, argc, argv, exec_argc, exec_argv); + Load(env); + return env; }