From: Sung Yoon Whang <suwhang@microsoft.com>
Date: Wed, 11 Sep 2019 22:35:05 +0000 (-0700)
Subject: Make gc/gc-collect profiles available (#441)
X-Git-Tag: submit/tizen/20191015.063341~10^2~1^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f61336dcb1eb762a147d9e44e1b170db5e730e61;p=platform%2Fcore%2Fdotnet%2Fdiagnostics.git

Make gc/gc-collect profiles available (#441)

* Make gc/gc-collect profiles available

* Add a new gc-verbose profile, rename existing gc profile to gc-with-heapsurvival, remove sampleprofiler from gc-collect

* gc-verbose only needs stack at gc events -- disabling sampleprofiler for this profile

* Remove gc-with-heapsurvival, update description for gc-verbose
---

diff --git a/src/Tools/dotnet-trace/CommandLine/Commands/ListProfilesCommandHandler.cs b/src/Tools/dotnet-trace/CommandLine/Commands/ListProfilesCommandHandler.cs
index d0cfe22a5..c0e33ea2f 100644
--- a/src/Tools/dotnet-trace/CommandLine/Commands/ListProfilesCommandHandler.cs
+++ b/src/Tools/dotnet-trace/CommandLine/Commands/ListProfilesCommandHandler.cs
@@ -48,28 +48,21 @@ namespace Microsoft.Diagnostics.Tools.Trace
                     new Provider("Microsoft-Windows-DotNETRuntime", (ulong)ClrTraceEventParser.Keywords.Default, EventLevel.Informational),
                 },
                 "Useful for tracking CPU usage and general runtime information. This the default option if no profile is specified."),
-#if DEBUG // Coming soon: Preview6
             new Profile(
-                "gc",
+                "gc-verbose",
                 new Provider[] {
-                    new Provider("Microsoft-DotNETCore-SampleProfiler"),
                     new Provider(
                         name: "Microsoft-Windows-DotNETRuntime",
                         keywords: (ulong)ClrTraceEventParser.Keywords.GC |
-                                  (ulong)ClrTraceEventParser.Keywords.GCHeapSurvivalAndMovement |
-                                  (ulong)ClrTraceEventParser.Keywords.Stack |
-                                  (ulong)ClrTraceEventParser.Keywords.Jit |
-                                  (ulong)ClrTraceEventParser.Keywords.StopEnumeration |
-                                  (ulong)ClrTraceEventParser.Keywords.SupressNGen |
-                                  (ulong)ClrTraceEventParser.Keywords.Loader |
+                                  (ulong)ClrTraceEventParser.Keywords.GCHandle |
                                   (ulong)ClrTraceEventParser.Keywords.Exception,
-                        eventLevel: EventLevel.Verbose),
+                        eventLevel: EventLevel.Verbose
+                    ),
                 },
-                "Tracks allocation and collection performance."),
+                "Tracks GC and GC handle events at verbose level, and samples the allocation events as well."),
             new Profile(
                 "gc-collect",
                 new Provider[] {
-                    new Provider("Microsoft-DotNETCore-SampleProfiler"),
                     new Provider(
                         name: "Microsoft-Windows-DotNETRuntime",
                         keywords:   (ulong)ClrTraceEventParser.Keywords.GC |
@@ -77,7 +70,6 @@ namespace Microsoft.Diagnostics.Tools.Trace
                         eventLevel: EventLevel.Informational),
                 },
                 "Tracks GC collection only at very low overhead."),
-#endif // DEBUG
             new Profile(
                 "none",
                 null,