From: Al Viro Date: Thu, 29 Apr 2021 00:59:08 +0000 (-0400) Subject: iterate_and_advance(): get rid of magic in case when n is 0 X-Git-Tag: accepted/tizen/unified/20230118.172025~6913^2~15 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f5da83545f4ed2c1a1648b7d760a6fc358798e52;p=platform%2Fkernel%2Flinux-rpi.git iterate_and_advance(): get rid of magic in case when n is 0 iov_iter_advance() needs to do some non-trivial work when it's given 0 as argument (skip all empty iovecs, mostly). We used to implement it via iterate_and_advance(); we no longer do so and for all other users of iterate_and_advance() zero length is a no-op. Signed-off-by: Al Viro --- diff --git a/lib/iov_iter.c b/lib/iov_iter.c index 93ae0c2c..763114a 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c @@ -117,7 +117,7 @@ #define iterate_and_advance(i, n, v, I, B, K, X) { \ if (unlikely(i->count < n)) \ n = i->count; \ - if (i->count) { \ + if (likely(n)) { \ size_t skip = i->iov_offset; \ if (likely(iter_is_iovec(i))) { \ const struct iovec *iov; \