From: yangerkun <yangerkun@huawei.com>
Date: Wed, 26 Feb 2020 03:54:35 +0000 (+0800)
Subject: slip: not call free_netdev before rtnl_unlock in slip_open
X-Git-Tag: v5.10.7~3149^2~15
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f596c87005f7b1baeb7d62d9a9e25d68c3dfae10;p=platform%2Fkernel%2Flinux-rpi.git

slip: not call free_netdev before rtnl_unlock in slip_open

As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.

Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
index 6f4d7ba..babb018 100644
--- a/drivers/net/slip/slip.c
+++ b/drivers/net/slip/slip.c
@@ -863,7 +863,10 @@ err_free_chan:
 	tty->disc_data = NULL;
 	clear_bit(SLF_INUSE, &sl->flags);
 	sl_free_netdev(sl->dev);
+	/* do not call free_netdev before rtnl_unlock */
+	rtnl_unlock();
 	free_netdev(sl->dev);
+	return err;
 
 err_exit:
 	rtnl_unlock();