From: Jeffy Chen Date: Mon, 12 Jun 2017 08:42:46 +0000 (+0800) Subject: mfd: cros_ec: Free IRQ on exit X-Git-Tag: v5.15~10940^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f58b14e6632a07ea1eb89aedb5e27cc55d251826;p=platform%2Fkernel%2Flinux-starfive.git mfd: cros_ec: Free IRQ on exit Currently we request the irq when probing, but never free it. So after unbind ec driver, this irq will be left requested, which would break the next bind: [ 2683.338437] genirq: Flags mismatch irq 64. 00002008 (chromeos-ec) vs. 00002008 (chromeos-ec) [ 2683.338591] cros-ec-spi spi5.0: request irq 64: error -16 [ 2683.338610] cros-ec-spi spi5.0: cannot register EC [ 2683.338656] cros-ec-spi: probe of spi5.0 failed with error -16 Signed-off-by: Jeffy Chen Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index e31ac60..dc6ce90 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c @@ -183,6 +183,9 @@ int cros_ec_remove(struct cros_ec_device *ec_dev) cros_ec_acpi_remove_gpe_handler(); + if (ec_dev->irq) + free_irq(ec_dev->irq, ec_dev); + return 0; } EXPORT_SYMBOL(cros_ec_remove);