From: Matthew Waters Date: Tue, 19 Aug 2014 10:14:22 +0000 (+1000) Subject: gl: don't take an extra ref on the display on set_context X-Git-Tag: accepted/tizen/unified/20220217.153506~2^2~10^2~9^2~12^2~2^2~260 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f55b274b3d58fc2262331504913af63267a5496a;p=platform%2Fupstream%2Fgstreamer.git gl: don't take an extra ref on the display on set_context gst_context_get_gl_display() returns a ref. Don't take another in gst_object_replace(). --- diff --git a/gst-libs/gst/gl/gstglutils.c b/gst-libs/gst/gl/gstglutils.c index 2d90714..2e1b0dd 100644 --- a/gst-libs/gst/gl/gstglutils.c +++ b/gst-libs/gst/gl/gstglutils.c @@ -767,8 +767,11 @@ gst_gl_handle_set_context (GstElement * element, GstContext * context, } #endif - if (replacement) - gst_object_replace ((GstObject **) display, (GstObject *) replacement); + if (replacement) { + GstGLDisplay *old = *display; + *display = replacement; + gst_object_unref (old); + } return TRUE; }