From: Stephen Hemminger Date: Mon, 8 May 2006 22:11:28 +0000 (-0700) Subject: sky2: tx ring index mask fix X-Git-Tag: accepted/tizen/common/20141203.182822~37669^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f55925d7eb04f936ab4c001f10e3e9c74c1297ae;p=platform%2Fkernel%2Flinux-arm64.git sky2: tx ring index mask fix Mask for transmit ring status was picking up bits from the unused sync ring. They were always zero, so far... Also, make sure to remind self not to make tx ring too big. Signed-off-by: Stephen Hemminger --- diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c index 552aca7..4bb6ea1 100644 --- a/drivers/net/sky2.c +++ b/drivers/net/sky2.c @@ -1927,7 +1927,8 @@ static int sky2_status_intr(struct sky2_hw *hw, int to_do) case OP_TXINDEXLE: /* TX index reports status for both ports */ - sky2_tx_done(hw->dev[0], status & 0xffff); + BUILD_BUG_ON(TX_RING_SIZE > 0x1000); + sky2_tx_done(hw->dev[0], status & 0xfff); if (hw->dev[1]) sky2_tx_done(hw->dev[1], ((status >> 24) & 0xff)