From: Sebastian Dröge <sebastian@centricular.com>
Date: Wed, 24 Feb 2021 17:51:40 +0000 (+0200)
Subject: audioaggregator: Log if the sample rate of one sinkpad is not accepted
X-Git-Tag: 1.19.3~511^2~262
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f5381ba9f5c20b62ad2d791404f4ccb47383b704;p=platform%2Fupstream%2Fgstreamer.git

audioaggregator: Log if the sample rate of one sinkpad is not accepted

Otherwise this can silently cause not-negotiated errors without any
direct hint about what went wrong.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1049>
---

diff --git a/gst-libs/gst/audio/gstaudioaggregator.c b/gst-libs/gst/audio/gstaudioaggregator.c
index dd6e7dd..85dbd2a 100644
--- a/gst-libs/gst/audio/gstaudioaggregator.c
+++ b/gst-libs/gst/audio/gstaudioaggregator.c
@@ -900,7 +900,8 @@ gst_audio_aggregator_sink_setcaps (GstAudioAggregatorPad * aaggpad,
   gboolean downstream_supports_rate = TRUE;
 
   if (!gst_audio_info_from_caps (&info, caps)) {
-    GST_WARNING_OBJECT (agg, "Rejecting invalid caps: %" GST_PTR_FORMAT, caps);
+    GST_WARNING_OBJECT (aaggpad, "Rejecting invalid caps: %" GST_PTR_FORMAT,
+        caps);
     return FALSE;
   }
 
@@ -933,6 +934,10 @@ gst_audio_aggregator_sink_setcaps (GstAudioAggregatorPad * aaggpad,
 
   if (!downstream_supports_rate || (first_configured_pad
           && info.rate != first_configured_pad->info.rate)) {
+    GST_WARNING_OBJECT (aaggpad,
+        "Sample rate %d can't be configured (downstream supported: %d, configured rate: %d)",
+        info.rate, downstream_supports_rate,
+        first_configured_pad ? first_configured_pad->info.rate : 0);
     gst_pad_push_event (GST_PAD (aaggpad), gst_event_new_reconfigure ());
     ret = FALSE;
   } else {