From: Wang Sheng-Hui Date: Wed, 24 Jul 2013 06:53:26 +0000 (+0800) Subject: bonding: use pre-defined macro in bond_mode_name instead of magic number 0 X-Git-Tag: v5.15~19424^2~460 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f52809483caceaf83bd2c7915a35ace3b6e7b0ef;p=platform%2Fkernel%2Flinux-starfive.git bonding: use pre-defined macro in bond_mode_name instead of magic number 0 We have BOND_MODE_ROUNDROBIN pre-defined as 0, and it's the lowest mode number. Use it to check the arg lower bound instead of magic number 0 in bond_mode_name. Signed-off-by: Wang Sheng-Hui Signed-off-by: David S. Miller --- diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 414d07e..fc10c12 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -273,7 +273,7 @@ const char *bond_mode_name(int mode) [BOND_MODE_ALB] = "adaptive load balancing", }; - if (mode < 0 || mode > BOND_MODE_ALB) + if (mode < BOND_MODE_ROUNDROBIN || mode > BOND_MODE_ALB) return "unknown"; return names[mode];