From: Jesper Juhl Date: Mon, 9 Apr 2012 20:51:19 +0000 (+0200) Subject: wireless, orinoco: release_firmware() tests for NULL, remove explicit tests before... X-Git-Tag: v3.5-rc1~109^2~410^2~119 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f5123117091995b94e17c44a43cbf4b5dd736319;p=platform%2Fkernel%2Flinux-exynos.git wireless, orinoco: release_firmware() tests for NULL, remove explicit tests before calls It is redundant to test for NULL pointers before calling release_firmware() since the function does its own NULL test. Signed-off-by: Jesper Juhl Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/orinoco/fw.c b/drivers/net/wireless/orinoco/fw.c index 4df8cf6..400a352 100644 --- a/drivers/net/wireless/orinoco/fw.c +++ b/drivers/net/wireless/orinoco/fw.c @@ -379,11 +379,8 @@ void orinoco_cache_fw(struct orinoco_private *priv, int ap) void orinoco_uncache_fw(struct orinoco_private *priv) { - if (priv->cached_pri_fw) - release_firmware(priv->cached_pri_fw); - if (priv->cached_fw) - release_firmware(priv->cached_fw); - + release_firmware(priv->cached_pri_fw); + release_firmware(priv->cached_fw); priv->cached_pri_fw = NULL; priv->cached_fw = NULL; }