From: neil Date: Sat, 15 Jul 2000 04:59:42 +0000 (+0000) Subject: * README.Portability: Correct example about calling a function X-Git-Tag: upstream/4.9.2~100338 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f4e03dfb01e5056bb8eab6846912f4a3d1d01e3a;p=platform%2Fupstream%2Flinaro-gcc.git * README.Portability: Correct example about calling a function through a pointer to function. Format wide paragraphs. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@35043 138bc75d-0d04-0410-961f-82ee72b054a4 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8a5201d..7199aea 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2000-07-15 Neil Booth + + * README.Portability: Correct example about calling a function + through a pointer to function. Format wide paragraphs. + 2000-07-15 Michael Meissner * README.Portability: Update integer suffixes and function diff --git a/gcc/README.Portability b/gcc/README.Portability index d6c8aec..cc5fa32 100644 --- a/gcc/README.Portability +++ b/gcc/README.Portability @@ -155,22 +155,23 @@ ansidecl.h for the definitions of the above macros and more. #define PARAMS(paramlist) () /* K+R C. */ #define VPARAMS(args) (va_alist) va_dcl -One aspect of using K+R style function declarations, is you cannot have -arguments whose types are char, short, or float, since without prototypes (ie, -K+R rules), these types are promoted to int, int, and double respectively. +One aspect of using K+R style function declarations, is you cannot +have arguments whose types are char, short, or float, since without +prototypes (ie, K+R rules), these types are promoted to int, int, and +double respectively. Calling functions through pointers to functions ----------------------------------------------- K+R C compilers require brackets around the dereferenced pointer -variable. For example +variable, whereas ISO C relaxes the syntax. For example typedef void (* cl_directive_handler) PARAMS ((cpp_reader *, const char *)); - p->handler (pfile, p->arg); + *p->handler (pfile, p->arg); needs to become - (p->handler) (pfile, p->arg); + (*p->handler) (pfile, p->arg); Macros @@ -244,11 +245,12 @@ them. Suffixes on Integer Constants ----------------------------- -K+R C did not accept a 'u' suffix on integer constants. If you want to declare -a constant to be be unsigned, you must use an explicit cast. +K+R C did not accept a 'u' suffix on integer constants. If you want +to declare a constant to be be unsigned, you must use an explicit +cast. -You should never use a 'l' suffix on integer constants ('L' is fine), since it -can easily be confused with the number '1'. +You should never use a 'l' suffix on integer constants ('L' is fine), +since it can easily be confused with the number '1'. Common Coding Pitfalls