From: Uwe Kleine-König Date: Mon, 8 May 2023 14:26:30 +0000 (+0200) Subject: net: stmmac: dwmac-visconti: Convert to platform remove callback returning void X-Git-Tag: v6.6.17~4555^2~312^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f4d05c41976170e29aac1bc51df22fb6989d1427;p=platform%2Fkernel%2Flinux-rpi.git net: stmmac: dwmac-visconti: Convert to platform remove callback returning void The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: Simon Horman Signed-off-by: Uwe Kleine-König Acked-by: Nobuhiro Iwamatsu Reviewed-by: Michal Kubiak Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c index 56209af6243c..acbb284be174 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c @@ -257,7 +257,7 @@ remove_config: return ret; } -static int visconti_eth_dwmac_remove(struct platform_device *pdev) +static void visconti_eth_dwmac_remove(struct platform_device *pdev) { struct net_device *ndev = platform_get_drvdata(pdev); struct stmmac_priv *priv = netdev_priv(ndev); @@ -267,8 +267,6 @@ static int visconti_eth_dwmac_remove(struct platform_device *pdev) visconti_eth_clock_remove(pdev); stmmac_remove_config_dt(pdev, priv->plat); - - return 0; } static const struct of_device_id visconti_eth_dwmac_match[] = { @@ -279,7 +277,7 @@ MODULE_DEVICE_TABLE(of, visconti_eth_dwmac_match); static struct platform_driver visconti_eth_dwmac_driver = { .probe = visconti_eth_dwmac_probe, - .remove = visconti_eth_dwmac_remove, + .remove_new = visconti_eth_dwmac_remove, .driver = { .name = "visconti-eth-dwmac", .of_match_table = visconti_eth_dwmac_match,