From: Qiushi Wu Date: Fri, 22 May 2020 18:45:18 +0000 (-0500) Subject: rxrpc: Fix a memory leak in rxkad_verify_response() X-Git-Tag: v5.10.7~2577^2~7^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f45d01f4f30b53c3a0a1c6c1c154acb7ff74ab9f;p=platform%2Fkernel%2Flinux-rpi.git rxrpc: Fix a memory leak in rxkad_verify_response() A ticket was not released after a call of the function "rxkad_decrypt_ticket" failed. Thus replace the jump target "temporary_error_free_resp" by "temporary_error_free_ticket". Fixes: 8c2f826dc3631 ("rxrpc: Don't put crypto buffers on the stack") Signed-off-by: Qiushi Wu Signed-off-by: David Howells cc: Markus Elfring --- diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 098f1f9..52a24d4 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -1148,7 +1148,7 @@ static int rxkad_verify_response(struct rxrpc_connection *conn, ret = rxkad_decrypt_ticket(conn, skb, ticket, ticket_len, &session_key, &expiry, _abort_code); if (ret < 0) - goto temporary_error_free_resp; + goto temporary_error_free_ticket; /* use the session key from inside the ticket to decrypt the * response */ @@ -1230,7 +1230,6 @@ protocol_error: temporary_error_free_ticket: kfree(ticket); -temporary_error_free_resp: kfree(response); temporary_error: /* Ignore the response packet if we got a temporary error such as