From: Tomasz Czekala Date: Fri, 30 Jan 2015 07:33:51 +0000 (+0100) Subject: Fix invalid check in utc_blink_ewk_view_application_name_for_user_agent_set X-Git-Tag: submit/tizen/20201118.160233~1357 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f3fa2211e5e9af18fda8f413be289ff4b166f728;p=platform%2Fframework%2Fweb%2Fchromium-efl.git Fix invalid check in utc_blink_ewk_view_application_name_for_user_agent_set When we call ewk_view_application_name_for_user_agent_set with application_name as NULL, we expect to get default application name for user agent Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9327 Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Grad, Piotr Tworek, arno renevier Change-Id: I9c8d4fccf3c55b99940d1413b45513f8d1c40819 Signed-off-by: Tomasz Czekala --- diff --git a/tizen_src/ewk/unittest/utc_blink_ewk_view_application_name_for_user_agent_set_func.cpp b/tizen_src/ewk/unittest/utc_blink_ewk_view_application_name_for_user_agent_set_func.cpp index a0807ce..11f580dd 100755 --- a/tizen_src/ewk/unittest/utc_blink_ewk_view_application_name_for_user_agent_set_func.cpp +++ b/tizen_src/ewk/unittest/utc_blink_ewk_view_application_name_for_user_agent_set_func.cpp @@ -14,7 +14,6 @@ class utc_blink_ewk_view_application_name_for_user_agent_set : public utc_blink_ TEST_F(utc_blink_ewk_view_application_name_for_user_agent_set, NullArg) { EXPECT_EQ(EINA_FALSE, ewk_view_application_name_for_user_agent_set(NULL, "")); - EXPECT_EQ(EINA_FALSE, ewk_view_application_name_for_user_agent_set(GetEwkWebView(), NULL)); } /** @@ -29,6 +28,13 @@ TEST_F(utc_blink_ewk_view_application_name_for_user_agent_set, POS_TEST) TEST_F(utc_blink_ewk_view_application_name_for_user_agent_set, EmptyString) { EXPECT_EQ(EINA_TRUE, ewk_view_application_name_for_user_agent_set(GetEwkWebView(), "")); - // if set empty string (not null) than assign PRODUCT_NAME (version_info_efl.h) + // if set empty string then assign PRODUCT_NAME (version_info_efl.h) + EXPECT_STREQ("efl-webengine", ewk_view_application_name_for_user_agent_get(GetEwkWebView())); +} + +TEST_F(utc_blink_ewk_view_application_name_for_user_agent_set, NullString) +{ + EXPECT_EQ(EINA_TRUE, ewk_view_application_name_for_user_agent_set(GetEwkWebView(), NULL)); + // if set NULL as string then assign PRODUCT_NAME (version_info_efl.h) EXPECT_STREQ("efl-webengine", ewk_view_application_name_for_user_agent_get(GetEwkWebView())); }