From: Przemyslaw Ciezkowski Date: Wed, 20 May 2015 12:38:51 +0000 (+0200) Subject: [FMRadio] Add throwing errors in methods X-Git-Tag: submit/tizen_mobile/20150612.133019^2~2^2~144^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f3b1627cf3ca35328ff794a6337d9ddf34f0188e;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git [FMRadio] Add throwing errors in methods start(), stop(), setFMRadioInterruptedListener(), unsetFMRadioInterruptedListener(), setAntennaChangeListener(), unsetAntennaChangeListener() are methods that can throw exception. [Verification] FMRadioManager_stop_invalid_state passes Change-Id: Iab2739e8b32fd17c47015c6b7ebead9f175883c0 Signed-off-by: Przemyslaw Ciezkowski --- diff --git a/src/radio/radio_api.js b/src/radio/radio_api.js index eacc8078..fc067673 100644 --- a/src/radio/radio_api.js +++ b/src/radio/radio_api.js @@ -140,7 +140,7 @@ function FMRadioManager() { name : 'mute', type : types_.BOOLEAN } ]); - var ret = native_.callSync('FMRadio_MuteSetter', args); + native_.callSync('FMRadio_MuteSetter', args); } function radioStateGetter() { @@ -190,7 +190,7 @@ FMRadioManager.prototype.seekUp = function() { nullable : true } ]); - var ret = native_.call('FMRadio_SeekUp', {}, function(result) { + native_.call('FMRadio_SeekUp', {}, function(result) { if (native_.isFailure(result)) { if (args.errorCallback) args.errorCallback(native_.getErrorObject(result)); @@ -239,7 +239,7 @@ FMRadioManager.prototype.seekDown = function() { nullable : true } ]); - var ret = native_.call('FMRadio_SeekDown', {}, function(result) { + native_.call('FMRadio_SeekDown', {}, function(result) { if (native_.isFailure(result)) { if (args.errorCallback) args.errorCallback(native_.getErrorObject(result)); @@ -264,7 +264,7 @@ FMRadioManager.prototype.scanStart = function() { scanCBmanager.FMRadioScanSet(args.radioScanCallback.onfrequencyfound); - var ret = native_.call('FMRadio_ScanStart', {}, function(result) { + native_.call('FMRadio_ScanStart', {}, function(result) { if (native_.isFailure(result)) { if (args.errorCallback) args.errorCallback(native_.getErrorObject(result)); @@ -278,6 +278,9 @@ FMRadioManager.prototype.scanStart = function() { FMRadioManager.prototype.stop = function() { var ret = native_.callSync('FMRadio_Stop'); + if (native_.isFailure(ret)) { + throw native_.getErrorObject(ret); + } }; FMRadioManager.prototype.scanStop = function() { @@ -293,7 +296,7 @@ FMRadioManager.prototype.scanStop = function() { nullable : true } ]); - var ret = native_.call('FMRadio_ScanStop', {}, function(result) { + native_.call('FMRadio_ScanStop', {}, function(result) { if (native_.isFailure(result)) { if (args.errorCallback) args.errorCallback(native_.getErrorObject(result)); @@ -313,16 +316,21 @@ FMRadioManager.prototype.setFMRadioInterruptedListener = function() { values : [ 'oninterrupted', 'oninterruptfinished' ] } ]); interruptedCBmanager.FMRadioInterruptedSet(args.interruptCallback.oninterrupted, - args.interruptCallback.oninterruptfinished) + args.interruptCallback.oninterruptfinished); var ret = native_.callSync('FMRadio_SetFMRadioInterruptedListener'); - + if (native_.isFailure(ret)) { + throw native_.getErrorObject(ret); + } }; FMRadioManager.prototype.unsetFMRadioInterruptedListener = function() { interruptedCBmanager.FMRadioInterruptedUnset(); var ret = native_.callSync('FMRadio_UnsetFMRadioInterruptedListener'); + if (native_.isFailure(ret)) { + throw native_.getErrorObject(ret); + } }; FMRadioManager.prototype.setAntennaChangeListener = function() { @@ -333,14 +341,18 @@ FMRadioManager.prototype.setAntennaChangeListener = function() { antennaCBmanager.FMRadioAntennaChangeSet(args.changeCallback); var ret = native_.callSync('FMRadio_SetAntennaChangeListener'); - + if (native_.isFailure(ret)) { + throw native_.getErrorObject(ret); + } }; FMRadioManager.prototype.unsetAntennaChangeListener = function() { antennaCBmanager.FMRadioAntennaUnset(); var ret = native_.callSync('FMRadio_UnsetAntennaChangeListener'); - + if (native_.isFailure(ret)) { + throw native_.getErrorObject(ret); + } }; exports = new FMRadioManager();