From: Daniel Mack <zonque@gmail.com>
Date: Wed, 21 Aug 2013 09:17:21 +0000 (+0200)
Subject: usb: ehci-mxc: check for pdata before dereferencing
X-Git-Tag: v3.12-rc1~186^2~30
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f375fc520d4df0cd9fcb570f33c103c6c0311f9e;p=platform%2Fkernel%2Flinux-stable.git

usb: ehci-mxc: check for pdata before dereferencing

Commit 7e8d5cd93fac ("USB: Add EHCI support for MX27 and MX31 based
boards") introduced code that could potentially lead to a NULL pointer
dereference on driver removal.

Fix this by checking for the value of pdata before dereferencing it.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable <stable@vger.kernel.org> # 2.6.33+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index 5899ad6..0528dc4 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -184,7 +184,7 @@ static int ehci_mxc_drv_remove(struct platform_device *pdev)
 	if (pdata && pdata->exit)
 		pdata->exit(pdev);
 
-	if (pdata->otg)
+	if (pdata && pdata->otg)
 		usb_phy_shutdown(pdata->otg);
 
 	clk_disable_unprepare(priv->usbclk);