From: Rahul Ruikar <rahul.ruikar@gmail.com>
Date: Wed, 20 Oct 2010 23:01:51 +0000 (-0700)
Subject: USB: gadget: amd5536udc.c: fix error path
X-Git-Tag: v3.0~3059^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f34c25ed78df6d1297db2187bf5e58aaf6674183;p=platform%2Fkernel%2Flinux-amlogic.git

USB: gadget: amd5536udc.c: fix error path

In function udc_probe() call put_device() when device_register() fails.

Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
Acked-by: Thomas Dahlmann <dahlmann.thomas@arcor.de>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index 2b36150..9034e034 100644
--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -3383,8 +3383,10 @@ static int udc_probe(struct udc *dev)
 	udc = dev;
 
 	retval = device_register(&dev->gadget.dev);
-	if (retval)
+	if (retval) {
+		put_device(&dev->gadget.dev);
 		goto finished;
+	}
 
 	/* timer init */
 	init_timer(&udc_timer);