From: Jim Lin <jim@andestech.com>
Date: Tue, 25 Jan 2022 07:05:43 +0000 (+0800)
Subject: [clang-tidy] Pop Files only if FileChangeReason is ExitFile
X-Git-Tag: upstream/15.0.7~19224
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f3314e3747873fdf026a28742a30f372503baf32;p=platform%2Fupstream%2Fllvm.git

[clang-tidy] Pop Files only if FileChangeReason is ExitFile

enum FileChangeReason has four possible type EnterFile, ExitFile,
SystemHeaderPragma and RenameFile,
It should pop the back element of Files only if FileChangeReason is ExitFile.
---

diff --git a/clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp b/clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp
index 681b839..a6e4943 100644
--- a/clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp
@@ -71,7 +71,7 @@ void DuplicateIncludeCallbacks::FileChanged(SourceLocation Loc,
                                             FileID PrevFID) {
   if (Reason == EnterFile)
     Files.emplace_back();
-  else
+  else if (Reason == ExitFile)
     Files.pop_back();
 }