From: pekon gupta Date: Thu, 20 Mar 2014 13:19:58 +0000 (+0530) Subject: mtd: nand: omap: fix BCHx ecc.correct to return detected bit-flips in erased-page X-Git-Tag: v4.14-rc1~7404^2~35 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f306e8c3b667632952f1a4a74ffb910bbc06255f;p=platform%2Fkernel%2Flinux-rpi.git mtd: nand: omap: fix BCHx ecc.correct to return detected bit-flips in erased-page fixes: commit 62116e5171e00f85a8d53f76e45b84423c89ff34 mtd: nand: omap2: Support for hardware BCH error correction. In omap_elm_correct_data(), if bitflip_count in an erased-page is within the correctable limit (< ecc.strength), then it is not indicated back to the caller ecc->read_page(). This mis-guides upper layers like MTD and UBIFS layer to assume erased-page as perfectly clean and use it for writing even if actual bitflip_count was dangerously high (bitflip_count > mtd->bitflip_threshold). This patch fixes this above issue, by returning 'stats' to caller ecc->read_page() under all scenarios. Reported-by: Brian Norris Signed-off-by: Pekon Gupta Cc: # 3.9.x+ Signed-off-by: Brian Norris --- diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index 1b800bc..10c319e 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1382,7 +1382,7 @@ static int omap_elm_correct_data(struct mtd_info *mtd, u_char *data, /* Check if any error reported */ if (!is_error_reported) - return 0; + return stat; /* Decode BCH error using ELM module */ elm_decode_bch_error_page(info->elm_dev, ecc_vec, err_vec);