From: Quentin Swain Date: Tue, 15 Aug 2017 01:48:17 +0000 (-0400) Subject: staging: pi433: replace logical not with bitwise X-Git-Tag: v4.14-rc1~148^2~261 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f2aee92d1865d8ff49fa7d715be638c849c650cf;p=platform%2Fkernel%2Flinux-rpi.git staging: pi433: replace logical not with bitwise sparse reports the following warning "warning: dubious: x & !y". Replaced te logical not with bitwise to resolve the warning Signed-off-by: Quentin Swain Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 85cd70d..3265786 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -197,7 +197,7 @@ int rf69_set_deviation(struct spi_device *spi, u32 deviation) lsb = (f_reg&0xff); // check msb - if (msb & !FDEVMASB_MASK) { + if (msb & ~FDEVMASB_MASK) { dev_dbg(&spi->dev, "set_deviation: err in calc of msb"); INVALID_PARAM; }