From: MyoungJune Park <mj2004.park@samsung.com>
Date: Wed, 21 Aug 2013 03:42:17 +0000 (+0900)
Subject: fixed N_SE-49233, toggle handler code was duplicated
X-Git-Tag: 2.2.1_release~9
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f2698a0822831adc556374904604dfce563a1959;p=apps%2Fhome%2Fsettings.git

fixed N_SE-49233, toggle handler code was duplicated

removed the duplicated code
---

diff --git a/setting-common/src/setting-common-plugin.c b/setting-common/src/setting-common-plugin.c
index c2b2837..7ee5bd4 100755
--- a/setting-common/src/setting-common-plugin.c
+++ b/setting-common/src/setting-common-plugin.c
@@ -874,6 +874,51 @@ static void* slider_func(void *data, xmlNode *xmlObj)
 	return (void*)list_item;
 };
 
+
+static void __checkbox_logic_helper(void *data, int toggle_state)
+{
+	Setting_GenGroupItem_Data *list_item = (Setting_GenGroupItem_Data *) data;
+
+	xmlNode* xmlObj = list_item->userdata;
+	ret_if(!xmlObj);
+
+	xmlAttrPtr newattr;
+	if (list_item->chk_status == 1) {
+		newattr = xmlSetProp(xmlObj, "value", "true");
+	} else if (list_item->chk_status == 0) {
+		newattr = xmlSetProp(xmlObj, "value", "false");
+	} else {
+		newattr = xmlSetProp(xmlObj, "value", "false");
+	}
+
+	const char *id = (char*)xmlGetProp(xmlObj, "id");
+	const char *title = (char*)xmlGetProp(xmlObj, "title");
+	//SETTING_TRACE(" >>>> id:%s , title:%s", id, title);
+	__send_int_msg(xmlObj, list_item->chk_status);
+	__cfg_file_write((Draw_Data *)list_item->belongs_to);
+}
+/**
+* @brief handler for 'toggle button'
+*
+* @see also __check_mouse_up_cb
+*/
+static void __chk_btn_cb(void *data, Evas_Object *obj, void *event_info)
+{
+	SETTING_TRACE_BEGIN;
+	/* error check */
+	retm_if(data == NULL, "Data parameter is NULL");
+	Setting_GenGroupItem_Data *list_item = (Setting_GenGroupItem_Data *) data;
+
+	list_item->chk_status = elm_check_state_get(obj);	/*  for genlist update status */
+
+	__checkbox_logic_helper(list_item, list_item->chk_status);
+	return;
+}
+
+
+/**
+* @brief handler for 'touching' line of genlist item
+*/
 static void __check_mouse_up_cb(void *data, Evas_Object *obj,
 					     void *event_info)
 {
@@ -892,43 +937,16 @@ static void __check_mouse_up_cb(void *data, Evas_Object *obj,
 	int old_status = elm_check_state_get(list_item->eo_check);
 	list_item->chk_status = !old_status;
 	elm_check_state_set(list_item->eo_check, list_item->chk_status);
-
+#if 0
 	xmlNode *xmlObj = data;
 	xmlAttrPtr newattr;
 	newattr = xmlSetProp(xmlObj, "state", xmlXPathCastNumberToString(list_item->chk_status));
 
 	__send_int_msg(xmlObj, list_item->chk_status);
 	__cfg_file_write((Draw_Data *)list_item->belongs_to);
-}
-
-
-static void __chk_btn_cb(void *data, Evas_Object *obj,
-					     void *event_info)
-{
-	SETTING_TRACE_BEGIN;
-	/* error check */
-	retm_if(data == NULL, "Data parameter is NULL");
-	Setting_GenGroupItem_Data *list_item = (Setting_GenGroupItem_Data *) data;
-
-	xmlNode* xmlObj = list_item->userdata;
-	ret_if(!xmlObj);
-	list_item->chk_status = elm_check_state_get(obj);	/*  for genlist update status */
-
-	xmlAttrPtr newattr;
-	if (list_item->chk_status == 1) {
-		newattr = xmlSetProp(xmlObj, "value", "true");
-	} else if (list_item->chk_status == 0) {
-		newattr = xmlSetProp(xmlObj, "value", "false");
-	} else {
-		newattr = xmlSetProp(xmlObj, "value", "false");
-	}
-
-	const char *id = (char*)xmlGetProp(xmlObj, "id");
-	const char *title = (char*)xmlGetProp(xmlObj, "title");
-	//SETTING_TRACE(" >>>> id:%s , title:%s", id, title);
-	__send_int_msg(xmlObj, list_item->chk_status);
-	__cfg_file_write((Draw_Data *)list_item->belongs_to);
-	return;
+#else
+	__checkbox_logic_helper(list_item, list_item->chk_status);
+#endif
 }