From: Arjun Sreedharan Date: Mon, 18 Aug 2014 05:47:33 +0000 (+0530) Subject: usb: phy: return -ENODEV on failure of try_module_get X-Git-Tag: submit/tizen/20160422.055611~1^2~99^2~11^2~189 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f259d867e35ffc1bd240d41c72278beec1faee33;p=sdk%2Femulator%2Femulator-kernel.git usb: phy: return -ENODEV on failure of try_module_get commit 2c4e3dbf63b39d44a291db70016c718f45d9cd46 upstream. When __usb_find_phy_dev() does not return error and try_module_get() fails, return -ENODEV. Signed-off-by: Arjun Sreedharan Signed-off-by: Felipe Balbi Cc: Mark Brown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 8afa813d690b..0180eef05656 100644 --- a/drivers/usb/phy/phy.c +++ b/drivers/usb/phy/phy.c @@ -229,6 +229,9 @@ struct usb_phy *usb_get_phy_dev(struct device *dev, u8 index) phy = __usb_find_phy_dev(dev, &phy_bind_list, index); if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) { dev_dbg(dev, "unable to find transceiver\n"); + if (!IS_ERR(phy)) + phy = ERR_PTR(-ENODEV); + goto err0; }