From: Iago Toral Quiroga Date: Fri, 31 Jul 2015 12:36:30 +0000 (+0200) Subject: i965/vec4: do not predicate scratch writes for BRW_OPCODE_SEL instructions X-Git-Tag: upstream/17.1.0~17034 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f246aa6bcab57f85a143cbfe7e9de24237921249;p=platform%2Fupstream%2Fmesa.git i965/vec4: do not predicate scratch writes for BRW_OPCODE_SEL instructions The dst is always written, in this case the predicate is only used to select the value to write, so if we are spilling the dst we always want to write whatever value we selected to scratch. Reviewed-by: Francisco Jerez --- diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index c5c0d2c..ba352be 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp @@ -3482,7 +3482,8 @@ vec4_visitor::emit_scratch_write(bblock_t *block, vec4_instruction *inst, dst_reg dst = dst_reg(brw_writemask(brw_vec8_grf(0, 0), inst->dst.writemask)); vec4_instruction *write = SCRATCH_WRITE(dst, temp, index); - write->predicate = inst->predicate; + if (inst->opcode != BRW_OPCODE_SEL) + write->predicate = inst->predicate; write->ir = inst->ir; write->annotation = inst->annotation; inst->insert_after(block, write);