From: Uwe Kleine-König Date: Mon, 18 Jul 2022 12:14:06 +0000 (+0200) Subject: interconnect: osm-l3: Ignore return value of icc_provider_del() in .remove() X-Git-Tag: v6.1-rc5~262^2~23^2^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f221bd781f25fa0ebb4c7e9553a9154a9722fd39;p=platform%2Fkernel%2Flinux-starfive.git interconnect: osm-l3: Ignore return value of icc_provider_del() in .remove() icc_provider_del() already emits an error message on failure. In this case letting .remove() return the corresponding error code results in another error message and the device is removed anyhow. (See platform_remove().) So ignore the return value of icc_provider_del() and return 0 unconditionally. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20220718121409.171773-6-u.kleine-koenig@pengutronix.de Signed-off-by: Georgi Djakov --- diff --git a/drivers/interconnect/qcom/osm-l3.c b/drivers/interconnect/qcom/osm-l3.c index 4198656..ddbdf09 100644 --- a/drivers/interconnect/qcom/osm-l3.c +++ b/drivers/interconnect/qcom/osm-l3.c @@ -217,7 +217,9 @@ static int qcom_osm_l3_remove(struct platform_device *pdev) struct qcom_osm_l3_icc_provider *qp = platform_get_drvdata(pdev); icc_nodes_remove(&qp->provider); - return icc_provider_del(&qp->provider); + icc_provider_del(&qp->provider); + + return 0; } static int qcom_osm_l3_probe(struct platform_device *pdev)