From: Dodji Seketeli <dodji@redhat.com>
Date: Fri, 24 Feb 2017 13:55:01 +0000 (+0100)
Subject: Do not ignore valgrind checks returning an error
X-Git-Tag: upstream/1.0~127
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f21ef03925a36c2e60e9cce1e87625ba709c7d54;p=platform%2Fupstream%2Flibabigail.git

Do not ignore valgrind checks returning an error

Under "make check-valgrindk", when valgrind returns errors, these
errors are ignored by make.  It turns out it is the autoconf
VALGRIND_CHECK_RULES macro that does this.  Fixed thus.

	* autoconf-archive/ax_valgrind_check.m4 (check-valgrind): Don't
	ignore errors.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---

diff --git a/autoconf-archive/ax_valgrind_check.m4 b/autoconf-archive/ax_valgrind_check.m4
index b18babe6..d0e3c2d0 100644
--- a/autoconf-archive/ax_valgrind_check.m4
+++ b/autoconf-archive/ax_valgrind_check.m4
@@ -184,10 +184,12 @@ else
 valgrind_lt =
 endif
 
-# Use recursive makes in order to ignore errors during check
+# Initial comment: Use recursive makes in order to ignore errors during check
+# Dodji Comment: We do not want to ignore errors during checks.
+# We want Make to keep going as much as it can.
 check-valgrind:
 ifeq ($(VALGRIND_ENABLED),yes)
-	-$(A''M_V_at)$(foreach tool,$(valgrind_enabled_tools), \
+	$(A''M_V_at)$(foreach tool,$(valgrind_enabled_tools), \
 		$(MAKE) $(AM_MAKEFLAGS) -k check-valgrind-$(tool); \
 	)
 else