From: Nithin Sujir Date: Thu, 23 May 2013 11:11:27 +0000 (+0000) Subject: tg3: Remove unnecessary lock around tg3_flag_set X-Git-Tag: v4.0~3666^2~317 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f2068b80ca59d63ca21ee1da829c9fe09f25b08e;p=platform%2Fkernel%2Flinux-amlogic.git tg3: Remove unnecessary lock around tg3_flag_set The spinlock was needed when flags used to be a u32 and set/cleared using bit operations. Now that we use the atomic set_bit, this lock isn't needed. Signed-off-by: Nithin Nayak Sujir Signed-off-by: Michael Chan Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index bd5917d8..d7755d8 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -6386,9 +6386,7 @@ static void tg3_tx_recover(struct tg3 *tp) "Please report the problem to the driver maintainer " "and include system chipset information.\n"); - spin_lock(&tp->lock); tg3_flag_set(tp, TX_RECOVERY_PENDING); - spin_unlock(&tp->lock); } static inline u32 tg3_tx_avail(struct tg3_napi *tnapi)