From: Mike McLaughlin Date: Fri, 21 Sep 2018 04:28:27 +0000 (-0700) Subject: Fix issue #20076 createdump faults. (#20084) X-Git-Tag: accepted/tizen/unified/20190422.045933~1151 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f1cf6e7172ae0f0fc3c4617c810d71c514c5e0ba;p=platform%2Fupstream%2Fcoreclr.git Fix issue #20076 createdump faults. (#20084) Return E_FAIL instead of S_FALSE from ClrDataFrame::GetLocalSig(). Also issue https://github.com/dotnet/diagnostics/issues/61 --- diff --git a/src/debug/daccess/stack.cpp b/src/debug/daccess/stack.cpp index b235366..2f69a02 100644 --- a/src/debug/daccess/stack.cpp +++ b/src/debug/daccess/stack.cpp @@ -1257,7 +1257,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig, { *sig = NULL; *count = 0; - return S_FALSE; + return E_FAIL; } COR_ILMETHOD_DECODER methodDecoder(m_methodDesc->GetILHeader()); @@ -1267,7 +1267,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig, { *sig = NULL; *count = 0; - return S_FALSE; + return E_FAIL; } ULONG tokenSigLen;