From: Kaixu Xia <kaixuxia@tencent.com>
Date: Tue, 13 Sep 2022 09:11:25 +0000 (+0800)
Subject: mm/damon/sysfs: simplify the variable 'pid' assignment operation
X-Git-Tag: v6.6.17~6355^2~148
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f1c71c2825218dc8b35c04ab439fdf3d32778c7c;p=platform%2Fkernel%2Flinux-rpi.git

mm/damon/sysfs: simplify the variable 'pid' assignment operation

We can initialize the variable 'pid' with '-1' in pid_show() to simplify
the variable assignment operation and make the code more readable.

Link: https://lkml.kernel.org/r/1663060287-30201-3-git-send-email-kaixuxia@tencent.com
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 3dbf380..1fa0023 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -2592,19 +2592,16 @@ static ssize_t pid_show(struct kobject *kobj,
 	struct damon_sysfs_kdamond *kdamond = container_of(kobj,
 			struct damon_sysfs_kdamond, kobj);
 	struct damon_ctx *ctx;
-	int pid;
+	int pid = -1;
 
 	if (!mutex_trylock(&damon_sysfs_lock))
 		return -EBUSY;
 	ctx = kdamond->damon_ctx;
-	if (!ctx) {
-		pid = -1;
+	if (!ctx)
 		goto out;
-	}
+
 	mutex_lock(&ctx->kdamond_lock);
-	if (!ctx->kdamond)
-		pid = -1;
-	else
+	if (ctx->kdamond)
 		pid = ctx->kdamond->pid;
 	mutex_unlock(&ctx->kdamond_lock);
 out: