From: Zheng Liu Date: Mon, 20 Feb 2012 22:53:05 +0000 (-0500) Subject: ext4: remove unneeded variable in ext4_xattr_check_block() X-Git-Tag: upstream/snapshot3+hdmi~7852^2~52 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f1b3a2a75356ce9fdcbedd79d2bb0d1ca8ed9cee;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ext4: remove unneeded variable in ext4_xattr_check_block() We could return directly from ext4_xattr_check_block(). Thus, we shouldn't need to define a 'error' variable. Signed-off-by: Zheng Liu Signed-off-by: "Theodore Ts'o" --- diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 93a00d8..1bff752 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -158,13 +158,10 @@ ext4_xattr_check_names(struct ext4_xattr_entry *entry, void *end) static inline int ext4_xattr_check_block(struct buffer_head *bh) { - int error; - if (BHDR(bh)->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC) || BHDR(bh)->h_blocks != cpu_to_le32(1)) return -EIO; - error = ext4_xattr_check_names(BFIRST(bh), bh->b_data + bh->b_size); - return error; + return ext4_xattr_check_names(BFIRST(bh), bh->b_data + bh->b_size); } static inline int