From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 9 Aug 2019 14:07:39 +0000 (+0300)
Subject: btrfs: fix error pointer check in __btrfs_map_block()
X-Git-Tag: v5.4-rc1~1^2~57
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=f11369897ed4f8609cdee00d3af47c18fe6bda29;p=platform%2Fkernel%2Flinux-rpi.git

btrfs: fix error pointer check in __btrfs_map_block()

The btrfs_get_chunk_map() never returns NULL, it returns error pointers.

Fixes: 89b798ad1b42 ("btrfs: Use btrfs_get_io_geometry appropriately")
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 48526923..e2de7c7 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6023,7 +6023,7 @@ static int __btrfs_map_block(struct btrfs_fs_info *fs_info,
 		return ret;
 
 	em = btrfs_get_chunk_map(fs_info, logical, *length);
-	ASSERT(em);
+	ASSERT(!IS_ERR(em));
 	map = em->map_lookup;
 
 	*length = geom.len;